Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not apply ExplicitBucketHistogramConfiguration to non-histograms #3126

Merged
merged 10 commits into from
Mar 31, 2022
Merged

Do not apply ExplicitBucketHistogramConfiguration to non-histograms #3126

merged 10 commits into from
Mar 31, 2022

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Mar 31, 2022 •
edited
Loading

No description provided.

@alanwest alanwest requested a review from a team March 31, 2022 19:02
@alanwest alanwest requested review from cijothomas and reyang March 31, 2022 20:45
@alanwest
Copy link
Member Author

Oops sorry. Just pushed the fix, so requesting another review.

@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #3126 (67371e4) into main (ac2a4f4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3126      +/-   ##
==========================================
- Coverage   84.71%   84.70%   -0.02%     
==========================================
  Files         259      259              
  Lines        9220     9232      +12     
==========================================
+ Hits         7811     7820       +9     
- Misses       1409     1412       +3
Impacted Files Coverage Δ
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 89.18% <100.00%> (+0.45%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-22.73%) ⬇️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <0.00%> (-14.29%) ⬇️
...mentation/ExportClient/BaseOtlpGrpcExportClient.cs 50.00% <0.00%> (-11.12%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 76.72% <0.00%> (+2.58%) ⬆️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 89.42% <0.00%> (+2.88%) ⬆️

alanwest added 3 commits March 31, 2022 14:37
@alanwest
Log warning message
6936c7e
@alanwest
Merge branch 'alanwest/its-a-bird-its-a-plane-its-not-a-histogram' of…
646232e 
… github.com:alanwest/opentelemetry-dotnet into alanwest/its-a-bird-its-a-plane-its-not-a-histogram
@alanwest
Update changelog
221d3f8
@cijothomas cijothomas merged commit 6c65569 into open-telemetry:main Mar 31, 2022
@alanwest alanwest deleted the alanwest/its-a-bird-its-a-plane-its-not-a-histogram branch April 1, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch left review comments

@cijothomas cijothomas cijothomas approved these changes

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alanwest @cijothomas @reyang @CodeBlanch