Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsoleExporter Log minor cosmetic improvement. #3211

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

cijothomas
Copy link
Member

Better padding.
Print TraceContext only if non-default, same with Event.
Group TraceContext fields (traceid,spanid,traceflags) together.

@cijothomas cijothomas requested a review from a team April 20, 2022 20:05
@TimothyMothra
Copy link
Contributor

could we also consider improving the padding for the Scope Key-Value pairs?

When printing the Resource attributes, we indent by 4 spaces (Line 90).
I think it would make it easier to read if we did the same at for Scope KVP (Line 80).

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #3211 (209276f) into main (eaa9370) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3211      +/-   ##
==========================================
+ Coverage   85.17%   85.23%   +0.05%     
==========================================
  Files         259      259              
  Lines        9345     9345              
==========================================
+ Hits         7960     7965       +5     
+ Misses       1385     1380       -5     
Impacted Files Coverage Δ
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 76.72% <0.00%> (+2.58%) ⬆️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 89.42% <0.00%> (+2.88%) ⬆️

@cijothomas
Copy link
Member Author

could we also consider improving the padding for the Scope Key-Value pairs?

When printing the Resource attributes, we indent by 4 spaces (Line 90). I think it would make it easier to read if we did the same at for Scope KVP (Line 80).

Fixed Resource.
Scopes can be a diff. PR.

@cijothomas cijothomas merged commit 50baa25 into open-telemetry:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants