Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP/Protobuf exporter for OTLP Logs #3225

Merged

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Apr 22, 2022

Covering one more gap in OTLP Logs!
Towards #2482

@cijothomas cijothomas requested a review from a team April 22, 2022 16:43
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #3225 (bb45fcb) into main (06d623b) will decrease coverage by 0.12%.
The diff coverage is 36.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
- Coverage   85.72%   85.60%   -0.13%     
==========================================
  Files         260      261       +1     
  Lines        9366     9390      +24     
==========================================
+ Hits         8029     8038       +9     
- Misses       1337     1352      +15     
Impacted Files Coverage Δ
...ementation/ExportClient/OtlpGrpcLogExportClient.cs 78.57% <ø> (ø)
...ementation/ExportClient/OtlpHttpLogExportClient.cs 0.00% <0.00%> (ø)
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 97.87% <100.00%> (+0.19%) ⬆️
....Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs 70.00% <100.00%> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (-15.00%) ⬇️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 72.72% <0.00%> (-13.64%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 92.34% <0.00%> (+0.90%) ⬆️
src/OpenTelemetry/BatchExportProcessor.cs 89.47% <0.00%> (+2.10%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (+5.88%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit d1ec45c into open-telemetry:main Apr 22, 2022
@cijothomas cijothomas deleted the cijothomas/otlp_log_httpclient branch April 28, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants