Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus Exporter - New .MapPrometheusScrapingEndpoint() Extension Method #3295

Merged
merged 14 commits into from
Jun 7, 2022
Merged

Prometheus Exporter - New .MapPrometheusScrapingEndpoint() Extension Method #3295

merged 14 commits into from
Jun 7, 2022

Conversation

hannahchan
Copy link
Contributor

Fixes #3267

Changes

Adds a new extension method MapPrometheusScrapingEndpoint() that extends off IEndpointRouteBuilder instead of IApplicationBuilder and returns an IEndpointConventionBuilder for chaining.

Please squash merge.

@hannahchan hannahchan requested a review from a team May 21, 2022 11:32
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 21, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

CodeBlanch
CodeBlanch approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch
Copy link
Member

@tillig If you have time would you mind also doing a review of this?

@codecov
Copy link

codecov bot commented May 25, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@c90ab4a). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3295   +/-   ##
=======================================
  Coverage        ?   85.72%           
=======================================
  Files           ?      267           
  Lines           ?     9383           
  Branches        ?        0           
=======================================
  Hits            ?     8044           
  Misses          ?     1339           
  Partials        ?        0
Impacted Files Coverage Δ
...rometheusExporterEndpointRouteBuilderExtensions.cs 100.00% <100.00%> (ø)

@tillig
Copy link
Contributor

tillig commented May 25, 2022

Just one comment about where services get resolved from, otherwise LGTM.

@cijothomas
Copy link
Member

@hannahchan could you fix the conflicts?
We just finished 1.3.0 release, and I am back to reviewing/merging all pending PRs..:)

@hannahchan
Copy link
Contributor Author

@cijothomas Yep done. Please let me know if you need anything else.

@hannahchan
Copy link
Contributor Author

Hi all,

The build failed and I think I've just fixed the issues I had with PublicAPI.Unshipped.txt. Please take a look when you get the chance.

Side note, the code fixes for Microsoft.CodeAnalysis.PublicApiAnalyzers don't seem to work in vscode.

@cijothomas cijothomas merged commit efc55d5 into open-telemetry:main Jun 7, 2022
@hannahchan hannahchan deleted the MapPrometheusScrapingEndpoint branch June 8, 2022 01:43
@msschl msschl mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillig tillig tillig left review comments

@CodeBlanch CodeBlanch CodeBlanch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better Dev Experience for UseOpenTelemetryPrometheusScrapingEndpoint() Extension Method
4 participants
@hannahchan @CodeBlanch @tillig @cijothomas