Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] circular buffer stress test #3355

Closed

Conversation

reyang
Copy link
Member

@reyang reyang commented Jun 9, 2022

Facilitates #3349.

The results before/after the change in 3349 (it might be pure noise, we probably need to run it multiple times to see what's the actual noise level):

image

@reyang reyang requested a review from a team June 9, 2022 05:30
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3355 (dfb7bd3) into main (2ab6281) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3355      +/-   ##
==========================================
- Coverage   86.14%   86.04%   -0.10%     
==========================================
  Files         268      268              
  Lines        9448     9448              
==========================================
- Hits         8139     8130       -9     
- Misses       1309     1318       +9     
Impacted Files Coverage Δ
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 86.53% <0.00%> (-5.77%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 74.57% <0.00%> (-1.70%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 95.60% <0.00%> (+1.09%) ⬆️

@reyang reyang requested a review from CodeBlanch June 9, 2022 05:51
@CodeBlanch
Copy link
Member

@reyang I just pushed some changes to #3349 to (primarily) speed up the reader. For me that dropped the time from 00:05:12.188 to 00:02:55.347. Would you mind running another test on your machine using latest?

@reyang reyang force-pushed the reyang/circular-buffer-stress branch from c09f2fe to dfb7bd3 Compare June 9, 2022 21:52
@reyang
Copy link
Member Author

reyang commented Jun 10, 2022

#3349 is ready to be merged, closing this PR.

@reyang reyang closed this Jun 10, 2022
@reyang reyang deleted the reyang/circular-buffer-stress branch June 10, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants