-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exponential Bucket Histogram - part 2 #3468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock progress. No change is user facing yet.
Codecov Report
@@ Coverage Diff @@
## main #3468 +/- ##
==========================================
+ Coverage 86.30% 86.48% +0.17%
==========================================
Files 267 268 +1
Lines 9634 9660 +26
==========================================
+ Hits 8315 8354 +39
+ Misses 1319 1306 -13
|
/// <summary> | ||
/// A histogram buckets implementation based on circular buffer. | ||
/// </summary> | ||
internal class CircularBufferBuckets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This we probably should seal for perf but also to prevent co-ops?
Following #3462.
Changes