Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PrometheusHttpListener options #3521

Merged
merged 7 commits into from
Aug 2, 2022
Merged

Improve PrometheusHttpListener options #3521

merged 7 commits into from
Aug 2, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Aug 2, 2022

Fixes #2840.

Changes

@reyang reyang requested a review from a team August 2, 2022 18:46
@reyang reyang closed this Aug 2, 2022
@reyang reyang reopened this Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022 •
edited
Loading

Codecov Report

Merging #3521 (454e0bf) into main (a1cdb28) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3521      +/-   ##
==========================================
- Coverage   86.61%   86.58%   -0.03%     
==========================================
  Files         275      275              
  Lines        9963     9958       -5     
==========================================
- Hits         8629     8622       -7     
- Misses       1334     1336       +2
Impacted Files Coverage Δ
....Prometheus.HttpListener/PrometheusHttpListener.cs 82.66% <100.00%> (+1.08%) ⬆️
...heus.HttpListener/PrometheusHttpListenerOptions.cs 100.00% <100.00%> (ø)
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-22.73%) ⬇️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <0.00%> (-14.29%) ⬇️
...theusHttpListenerMeterProviderBuilderExtensions.cs 75.00% <0.00%> (+16.66%) ⬆️

CodeBlanch
CodeBlanch approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great to see all the effort to split the projects up finally bearing fruit 😄

@reyang reyang force-pushed the reyang/prometheus-options branch from 70365f4 to 56d94c2 Compare August 2, 2022 22:15
@cijothomas cijothomas merged commit 27658f0 into open-telemetry:main Aug 2, 2022
@reyang reyang deleted the reyang/prometheus-options branch August 2, 2022 22:40
@m-standfuss m-standfuss mentioned this pull request Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyMothra TimothyMothra TimothyMothra left review comments

@Kielek Kielek Kielek left review comments

@utpilla utpilla utpilla approved these changes

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@Yun-Ting Yun-Ting Yun-Ting approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HttpListenerPrefixes other than localhost
7 participants
@reyang @cijothomas @Kielek @Yun-Ting @CodeBlanch @TimothyMothra @utpilla