-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InMemoryExporter] Throw ObjectDisposedException if Export happened after disposal #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3607 +/- ##
==========================================
+ Coverage 87.12% 87.22% +0.09%
==========================================
Files 277 277
Lines 9944 9950 +6
==========================================
+ Hits 8664 8679 +15
+ Misses 1280 1271 -9
|
CodeBlanch
reviewed
Aug 26, 2022
CodeBlanch
reviewed
Aug 26, 2022
CodeBlanch
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CodeBlanch
changed the title
Throw ObjectDisposedException if Export happened after disposal
[InMemoryExporter] Throw ObjectDisposedException if Export happened after disposal
Aug 26, 2022
CodeBlanch
reviewed
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1848 and #3578.
This should help the developers catch the bugs during the development / unit testing.