-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks for sampler accessing and modifying tracestate #3613
Merged
cijothomas
merged 7 commits into
open-telemetry:main
from
cijothomas:cijothomas/sampler-benchmark1
Aug 30, 2022
Merged
Benchmarks for sampler accessing and modifying tracestate #3613
cijothomas
merged 7 commits into
open-telemetry:main
from
cijothomas:cijothomas/sampler-benchmark1
Aug 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Aug 29, 2022
reyang
reviewed
Aug 29, 2022
reyang
reviewed
Aug 29, 2022
{ | ||
public class SamplerBenchmarks | ||
{ | ||
private readonly ActivitySource source = new("SamplerBenchmarks"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider something like
using var meter = new Meter(Utils.GetCurrentMethodName()); |
reyang
approved these changes
Aug 29, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3613 +/- ##
==========================================
+ Coverage 87.10% 87.31% +0.20%
==========================================
Files 280 280
Lines 10073 10073
==========================================
+ Hits 8774 8795 +21
+ Misses 1299 1278 -21
|
utpilla
reviewed
Aug 30, 2022
utpilla
reviewed
Aug 30, 2022
cijothomas
changed the title
Basic benchmark sampler
Benchmarks for sampler accessing and modifying tracestate
Aug 30, 2022
utpilla
approved these changes
Aug 30, 2022
Kielek
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding benchmarks for samplers, specifically targetting the impact of accessing/modifying tracestate inside sampler.
Related to #3610