Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks for sampler accessing and modifying tracestate #3613

Merged

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Aug 29, 2022

Adding benchmarks for samplers, specifically targetting the impact of accessing/modifying tracestate inside sampler.
Related to #3610

@cijothomas cijothomas requested a review from a team August 29, 2022 22:37
{
public class SamplerBenchmarks
{
private readonly ActivitySource source = new("SamplerBenchmarks");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider something like

using var meter = new Meter(Utils.GetCurrentMethodName());
?

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #3613 (468bc62) into main (b54cc80) will increase coverage by 0.20%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3613      +/-   ##
==========================================
+ Coverage   87.10%   87.31%   +0.20%     
==========================================
  Files         280      280              
  Lines       10073    10073              
==========================================
+ Hits         8774     8795      +21     
+ Misses       1299     1278      -21     
Impacted Files Coverage Δ
src/OpenTelemetry.Api/BaseProvider.cs 66.66% <0.00%> (-33.34%) ⬇️
...Listener/Internal/PrometheusExporterEventSource.cs 16.66% <0.00%> (-11.12%) ⬇️
....Prometheus.HttpListener/PrometheusHttpListener.cs 78.66% <0.00%> (-4.00%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 80.48% <0.00%> (+2.43%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 95.05% <0.00%> (+3.29%) ⬆️
...Telemetry/Metrics/PeriodicExportingMetricReader.cs 78.18% <0.00%> (+5.45%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️
src/OpenTelemetry/ProviderExtensions.cs 90.90% <0.00%> (+9.09%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
... and 1 more

@cijothomas cijothomas changed the title Basic benchmark sampler Benchmarks for sampler accessing and modifying tracestate Aug 30, 2022
@cijothomas cijothomas merged commit b082922 into open-telemetry:main Aug 30, 2022
@cijothomas cijothomas deleted the cijothomas/sampler-benchmark1 branch August 30, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants