-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Traces + Logs] Clean up repo exporters to use new DI patterns #3640
Conversation
// TODO: exporterOptions.BatchExportProcessorOptions is | ||
// BatchExportActivityProcessorOptions which is using tracing | ||
// environment variables. There should probably be a dedicated | ||
// setting for logs using BatchExportLogRecordProcessorOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanwest You want me to spin up an issue for this?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3640 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 282 282
Lines 10132 10142 +10
=======================================
+ Hits 8851 8860 +9
- Misses 1281 1282 +1
|
Will the same change come to metrics?
|
Totally! My goal is for all three signals to have the same (~) API for build-up. I'll start on metrics after a couple of these clean-up PRs for traces + logs. |
Changes
Updates the trace & logging exporters to use the new DI API surface.
OtlpLogExporter
got a couple features with this upgrade:IOptions
so it can be bound toIConfiguration
TryEnableIHttpClientFactoryIntegration
helper so it should also be able to useHttpClientFactory
integrationTODOs
CHANGELOG.md
updated for non-trivial changes