-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change StatusCode to 200 when no metrics are collected #3643
Merged
cijothomas
merged 3 commits into
open-telemetry:main
from
dszmigielski:fix-prometheus-exporter
Sep 11, 2022
Merged
Change StatusCode to 200 when no metrics are collected #3643
cijothomas
merged 3 commits into
open-telemetry:main
from
dszmigielski:fix-prometheus-exporter
Sep 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dszmigielski
force-pushed
the
fix-prometheus-exporter
branch
from
September 9, 2022 08:53
2a8373a
to
dde3ba2
Compare
Kielek
reviewed
Sep 9, 2022
Kielek
reviewed
Sep 9, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3643 +/- ##
==========================================
+ Coverage 87.22% 87.29% +0.06%
==========================================
Files 282 282
Lines 10132 10132
==========================================
+ Hits 8838 8845 +7
+ Misses 1294 1287 -7
|
cijothomas
approved these changes
Sep 9, 2022
Kielek
approved these changes
Sep 9, 2022
reyang
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would be even better to have a test case.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3582.
Changes
If Prometheus Exporter have no metrics to collect it reports StatusCode 200 now instead of 204.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes* [ ] Design discussion issue #* [ ] Changes in public API reviewed