-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] Clean up repo exporters to use new DI patterns #3648
Merged
CodeBlanch
merged 8 commits into
open-telemetry:main
from
CodeBlanch:exporter-cleanup-2
Sep 13, 2022
Merged
[Metrics] Clean up repo exporters to use new DI patterns #3648
CodeBlanch
merged 8 commits into
open-telemetry:main
from
CodeBlanch:exporter-cleanup-2
Sep 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Sep 12, 2022
alanwest
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Named options.. nice!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3648 +/- ##
==========================================
+ Coverage 87.62% 87.87% +0.24%
==========================================
Files 284 283 -1
Lines 10195 10215 +20
==========================================
+ Hits 8933 8976 +43
+ Misses 1262 1239 -23
|
[Updated the description with info about why the named options got introduced.] |
This was referenced Sep 13, 2022
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the metric exporters to use the new DI API surface.
Adds support for named options in metric exporter registrations.
The SdkSupportsMultipleReaders test exposed an issue with our pattern! We are doing
serviceProvider.GetRequiredService<IOptions<OptionsType>>()
everywhere. That is giving us (more or less) a global options instance (really what it does is just use the default name). Works fine when only a single exporter is registered, but if multiple are in play there be dragons. To solve this I added overloads where users can specify a name to control the options. Users who don't need this don't need to do anything they will just continue to use the default instance.TODOs