Guard.Range now uses invariant culture for error message

[Driedas]

Changes

while working on another PR the

public void RangeDoubleTest()

kept failing. The Guard.Range method constructs an error message with the current (ambient) culture, thus yielding different results for different culture settings.
In order to reproduce, add e. g.

CultureInfo.CurrentCulture = new CultureInfo("de-DE");

to the beginning of the test. Any culture that doesn't use the dot as the decimal separator will break the test.

I've changed the logic that calculates the error message to instead use the invariant culture explicitly (if you prefer another solution, feel free to throw this away)

var exMessage = message ?? string.Format(
    CultureInfo.InvariantCulture,
    "Must be in the range: [{0}{1}, {2}{3}]",
    min,
    minMessage,
    max,
    maxMessage);

A very minor thing, but I think tests should work regardless of the regional settings...

[codecov]

Codecov Report

Merging #3778 (b505d89) into main (d4cbc0c) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b505d89 differs from pull request most recent head 4c60de0. Consider uploading reports for the commit 4c60de0 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3778      +/-   ##
==========================================
+ Coverage   87.35%   87.36%   +0.01%     
==========================================
  Files         280      281       +1     
  Lines       10772    10758      -14     
==========================================
- Hits         9410     9399      -11     
+ Misses       1362     1359       -3     

Impacted Files	Coverage Δ
src/OpenTelemetry.Api/Internal/Guard.cs	100.00% <ø> (ø)
...racerProviderBuilderServiceCollectionExtensions.cs	85.71% <0.00%> (-14.29%)	⬇️
src/OpenTelemetry/Trace/SamplingResult.cs	88.57% <0.00%> (-11.43%)	⬇️
...etryProtocol/Implementation/LogRecordExtensions.cs	85.88% <0.00%> (-2.36%)	⬇️
...enTelemetry/Resources/ResourceBuilderExtensions.cs	92.00% <0.00%> (-0.86%)	⬇️
...emetry/Trace/Builder/TracerProviderBuilderState.cs	94.73% <0.00%> (-0.51%)	⬇️
src/OpenTelemetry/Trace/ExceptionProcessor.cs	90.90% <0.00%> (-0.40%)	⬇️
...lemetry/Trace/Builder/TracerProviderBuilderBase.cs	91.50% <0.00%> (-0.16%)	⬇️
src/OpenTelemetry/Metrics/MeterProviderSdk.cs	90.87% <0.00%> (-0.09%)	⬇️
src/OpenTelemetry/Trace/TracerProviderSdk.cs	99.63% <0.00%> (-0.01%)	⬇️
... and 28 more

[mic-max]

Is this the test and assert that will fail https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/test/OpenTelemetry.Tests/Internal/GuardTest.cs#L136?

And to confirm it is because in de-DE culture the Exception will be created with the message as: Must be in the range: [0,1: empty, 99,9: full] using commas instead of periods to separate the whole number and the mantissa?

Thanks for contributing! I think this is a good change that will give us consistent error messages and fix that flaky test :)

PS: Speaking of flaky tests, I think the CI failure is caused by one, please push an empty commit to rerun the CI :)

[Driedas]

Is this the test and assert that will fail https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/test/OpenTelemetry.Tests/Internal/GuardTest.cs#L136?

eeeexactly, that's the one...

And to confirm it is because in de-DE culture the Exception will be created with the message as: Must be in the range: [0,1: empty, 99,9: full] using commas instead of periods to separate the whole number and the mantissa?

and right again, sorry, should've explained it better in the description :)

Right, will push another foobar commit...

[reyang]

Might be a good idea to have CI running using different culture/locale.