Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logs-branch] Support loading OtlpLogExporter envvars from IConfiguration #3812

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Oct 24, 2022

Relates to #3760

Changes

Applies the IConfiguration pattern to OtlpLogExporter paths.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team October 24, 2022 21:24
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #3812 (095a8e9) into main-logs (aba8a69) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 095a8e9 differs from pull request most recent head 1830453. Consider uploading reports for the commit 1830453 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           main-logs    #3812      +/-   ##
=============================================
+ Coverage      87.60%   87.62%   +0.01%     
=============================================
  Files            304      304              
  Lines          11476    11491      +15     
=============================================
+ Hits           10054    10069      +15     
  Misses          1422     1422              
Impacted Files Coverage Δ
...ryProtocol.Logs/OtlpLogExporterHelperExtensions.cs 71.42% <100.00%> (+10.31%) ⬆️
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 94.73% <100.00%> (ø)
...lder/ProviderBuilderServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...Telemetry/Logs/Builder/LoggerProviderBuilderSdk.cs 96.55% <100.00%> (ø)
....Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs 66.66% <0.00%> (-8.34%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...p/Implementation/HttpInstrumentationEventSource.cs 72.00% <0.00%> (-4.00%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️
src/OpenTelemetry/BatchExportProcessor.cs 84.11% <0.00%> (+1.86%) ⬆️
... and 1 more

@CodeBlanch CodeBlanch merged commit 2f6e7e3 into open-telemetry:main-logs Oct 24, 2022
@CodeBlanch CodeBlanch deleted the otlp-log-options branch October 24, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants