Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram MinMax API fixes #3822

Merged

Conversation

cijothomas
Copy link
Member

See #2735 (comment) for the discussion.
Will add changelog once this is agreed.

@cijothomas cijothomas requested a review from a team October 26, 2022 00:13
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #3822 (e4ed4d9) into main (004c3f6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3822      +/-   ##
==========================================
- Coverage   87.41%   87.41%   -0.01%     
==========================================
  Files         280      280              
  Lines       10763    10767       +4     
==========================================
+ Hits         9409     9412       +3     
- Misses       1354     1355       +1     
Impacted Files Coverage Δ
...tryProtocol/Implementation/MetricItemExtensions.cs 93.95% <100.00%> (ø)
src/OpenTelemetry/Metrics/MetricPoint.cs 75.44% <100.00%> (+0.44%) ⬆️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 73.62% <0.00%> (-2.20%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️
...lementation/SqlClientInstrumentationEventSource.cs 75.00% <0.00%> (+4.16%) ⬆️

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 88c1864 into open-telemetry:main Oct 26, 2022
@cijothomas cijothomas deleted the cijothomas/histogram-minmax branch October 26, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants