Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs] Support dependency injection in ResourceBuilder and load envvars from IConfiguration #3889

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Nov 10, 2022

Relates to #3782

Changes

#3782 added support in Tracing & Metrics but didn't address Logging. This PR fixes that so everything is nice and consistent.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team November 10, 2022 21:32
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #3889 (ec419f6) into main (b5e50b2) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3889      +/-   ##
==========================================
+ Coverage   87.31%   87.39%   +0.08%     
==========================================
  Files         279      279              
  Lines       10774    10782       +8     
==========================================
+ Hits         9407     9423      +16     
+ Misses       1367     1359       -8     
Impacted Files Coverage Δ
.../OpenTelemetry/Logs/OpenTelemetryLoggerProvider.cs 91.75% <100.00%> (-1.66%) ⬇️
...enTelemetry/Logs/OpenTelemetryLoggingExtensions.cs 100.00% <100.00%> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 82.53% <0.00%> (+2.38%) ⬆️
...Listener/Internal/PrometheusExporterEventSource.cs 66.66% <0.00%> (+5.55%) ⬆️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 92.30% <0.00%> (+5.76%) ⬆️

@CodeBlanch CodeBlanch merged commit ddcff7d into open-telemetry:main Nov 11, 2022
@CodeBlanch CodeBlanch deleted the loggerprovider-resource-iconfiguration branch November 11, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants