-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hosting] Remove obsolete methods ahead of 1.4.0 release #4071
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
==========================================
+ Coverage 85.55% 85.71% +0.15%
==========================================
Files 291 289 -2
Lines 11398 11374 -24
==========================================
- Hits 9752 9749 -3
+ Misses 1646 1625 -21
|
src/OpenTelemetry.Extensions.Hosting/OpenTelemetry.Extensions.Hosting.csproj
Outdated
Show resolved
Hide resolved
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
bump to remove stale |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 LGTM.
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
* Bump OTEL & xUnit Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Fix breaking change open-telemetry/opentelemetry-dotnet#4071 Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Bump Arcus deps Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Fix code quality Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Fix failing test Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Bump System.Drawing.Common to fix vulnerability Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> --------- Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
If you are reading this because you upgraded to 1.4.0 and your code no longer compiles, sorry! Much discussion went into this and we decided as a group it was the best path forward to not have obsolete code in our first shipped stable version. If you want to get up and running using the old API, you may use the RC version: 1.4.0-rc.4. That version contains everything in 1.4.0 minus this PR removing the old API.
Migration steps
Old style:
New style:
Other APIs...
Configure
is available by casting the provider builder as eitherIDeferredTracerProviderBuilder
orIDeferredMeterProviderBuilder
.GetServices
is now available asConfigureServices
.Changes
TODOs
CHANGELOG.md
updated for non-trivial changes