Add support for OTEL_SERVICE_VERSION environment variable #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for detecting the service version from the `OTEL_SERVICE_VERSION` environment variable.
Add pull request to `CHANGELOG`.
|
I generally like the idea, but I think that this is a blocker: open-telemetry/opentelemetry-specification#1901 |
reyang
added
the
needs-spec-change
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
|
Closing this as we cannot merge w/o a spec change. Would you open an issue to track this? (stale prs get closed out anyway) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for detecting the service version from the
OTEL_SERVICE_VERSIONenvironment variable like the Ruby SDK supports.The only bit I'm unsure of is the change to the Zipkin span helper for
serviceVersionas I'm not familiar with Zipkin so don't know whether that's actually a thing.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes