-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Remove the dependency on M.E.Options 5.0 #4093
[SDK] Remove the dependency on M.E.Options 5.0 #4093
Conversation
@@ -31,7 +31,7 @@ internal sealed class SdkLimitOptions | |||
private int? spanLinkAttributeCountLimit; | |||
private bool spanLinkAttributeCountLimitSet; | |||
|
|||
internal SdkLimitOptions() | |||
public SdkLimitOptions() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The class is still internal
this just satisfies the new()
constraint which Options 3.1 requires of TOptions.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4093 +/- ##
==========================================
+ Coverage 85.46% 85.56% +0.10%
==========================================
Files 292 293 +1
Lines 11306 11330 +24
==========================================
+ Hits 9663 9695 +32
+ Misses 1643 1635 -8
|
} | ||
foreach (IPostConfigureOptions<TOptions> post in _postConfigures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
} | |
foreach (IPostConfigureOptions<TOptions> post in _postConfigures) | |
} | |
foreach (IPostConfigureOptions<TOptions> post in _postConfigures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Relates to #4084
Changes
Removes the direct reference to Microsoft.Extensions.Options 5.0 from SDK and instead pulls in the newer OptionsFactory bits with some modifications for what SDK needs.
TODOs
CHANGELOG.md
updated for non-trivial changes