-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk] Remove System.Reflection.Emit.Lightweight dependency #4140
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4140 +/- ##
==========================================
- Coverage 85.54% 85.48% -0.06%
==========================================
Files 293 293
Lines 11371 11371
==========================================
- Hits 9727 9721 -6
- Misses 1644 1650 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider to put information about direct dependency i OTLP CHANGELOG (I know that it was transitively available).
<PackageReference Include="Google.Protobuf" Version="$(GoogleProtobufPkgVer)" /> | ||
<PackageReference Include="Grpc.Tools" Version="$(GrpcToolsPkgVer)" PrivateAssets="all" /> | ||
<PackageReference Include="System.Reflection.Emit.Lightweight" Version="$(SystemReflectionEmitLightweightPkgVer)" Condition="'$(TargetFramework)' != 'net6.0'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those curious, OTLP Exporter uses a couple dynamic methods to reset the count of RepeatedField
s so they may be reused to avoid some allocations. Example here. A while back we were able to get a change put into Protobuf to make the default clear behavior capacity-preserving. I just checked, there is 3.22.0-rc1 which includes the change. So it seems we will be able to clean this up soon!
Changes
System.Reflection.Emit.Lightweight
dependency from SDK (it is no longer needed).System.Reflection.Emit.Lightweight
dependency toOpenTelemetry.Exporter.OpenTelemetryProtocol
where it is currently needed.TODOs
CHANGELOG.md
updated for non-trivial changes