[sdk] SuppressInstrumentationScope perf tweaks #4304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tweaked the implementation of
SuppressInstrumentationScope
to achieve better perf.Before...
int
in the context slot. Thatint
had to be boxed when scopes were created and we boxed a 0 when scopes were disposed.int
to the context slot which had to be boxed AND creates a newExecutionContext
.After...
SuppressInstrumentationScope
instance itself in the context slot. That avoids the boxing and gives us storage for the reference count which we can increment/decrement freely without creating any newExecutionContext
s.Benchmarks
Before:
After:
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes