Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AspNetCore] Avoid boxing of status code tags #4360

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Apr 4, 2023

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team April 4, 2023 17:19
@reyang
Copy link
Member

reyang commented Apr 4, 2023

@vishweshbankwar FYI

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #4360 (0fe5fdf) into main (6918866) will increase coverage by 0.08%.
The diff coverage is 98.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4360      +/-   ##
==========================================
+ Coverage   84.77%   84.85%   +0.08%     
==========================================
  Files         298      299       +1     
  Lines       11984    12057      +73     
==========================================
+ Hits        10159    10231      +72     
- Misses       1825     1826       +1     
Impacted Files Coverage Δ
...ation.AspNetCore/Implementation/TelemetryHelper.cs 98.63% <98.63%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 90.30% <100.00%> (ø)
...AspNetCore/Implementation/HttpInMetricsListener.cs 74.35% <100.00%> (ø)

... and 4 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit b2fb873 into open-telemetry:main Apr 4, 2023
@CodeBlanch CodeBlanch deleted the aspnetcore-statuscode-boxing branch April 4, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants