-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-logs] Implement LoggerProviderSdk #4453
[sdk-logs] Implement LoggerProviderSdk #4453
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4453 +/- ##
==========================================
- Coverage 84.11% 83.47% -0.64%
==========================================
Files 312 312
Lines 12367 12469 +102
==========================================
+ Hits 10402 10408 +6
- Misses 1965 2061 +96
|
|
||
public void AddProcessor(BaseProcessor<LogRecord> processor) | ||
{ | ||
OpenTelemetrySdkEventSource.Log.LoggerProviderSdkEvent("Started adding processor."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't need this as this should cover it:
OpenTelemetrySdkEventSource.Log.LoggerProviderSdkEvent($"Processors added = \"{processorsAdded}\".");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here because AddProcessor
can be called after the provider has been created! But agree, it is wonky. I just took a stab at cleaning it all up. Pushed a couple ToString
implementations into public API. LMK what you think about it now!
Relates to #4433
Changes
LoggerProviderSdk
in SDK.Merge requirement checklist