[sdk-logs] Tests and bug fixes for logging builder & provider #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
utpilla
reviewed
May 5, 2023
| using var provider = Sdk.CreateLoggerProviderBuilder() | ||
| .ConfigureServices(services => | ||
| { | ||
| if (callNestedConfigure) |
There was a problem hiding this comment.
Do we not want to assert something specific based on callNestedConfigure?
There was a problem hiding this comment.
I wrote that test so long ago I can't remember, TBH. I added an assert in the logging one and its cousins in tracing & metrics. I figured it couldn't hurt 😄
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4467 +/- ##
==========================================
+ Coverage 83.32% 85.01% +1.68%
==========================================
Files 314 314
Lines 12522 12524 +2
==========================================
+ Hits 10434 10647 +213
+ Misses 2088 1877 -211
|
utpilla
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4433
Changes
Merge requirement checklist