Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-logs] Update ILogger integration to use LoggerProvider #4473

Merged
merged 5 commits into from
May 10, 2023

Conversation

CodeBlanch
Copy link
Member

Relates to #4433

Changes

  • Updates the ILogger integration inside SDK to use the LoggerProvider bits

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated

@CodeBlanch CodeBlanch requested a review from a team May 9, 2023 17:47
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #4473 (d6642cc) into main (fea6793) will increase coverage by 0.07%.
The diff coverage is 91.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4473      +/-   ##
==========================================
+ Coverage   85.02%   85.10%   +0.07%     
==========================================
  Files         314      314              
  Lines       12524    12524              
==========================================
+ Hits        10649    10659      +10     
+ Misses       1875     1865      -10     
Impacted Files Coverage Δ
src/OpenTelemetry/ProviderExtensions.cs 91.66% <60.00%> (-3.79%) ⬇️
.../OpenTelemetry/Logs/ILogger/OpenTelemetryLogger.cs 87.73% <87.50%> (-0.02%) ⬇️
...emetry/Logs/ILogger/OpenTelemetryLoggerProvider.cs 95.16% <97.29%> (+4.07%) ⬆️
...lemetry/Logs/ILogger/OpenTelemetryLoggerOptions.cs 85.00% <100.00%> (-15.00%) ⬇️
...try/Logs/ILogger/OpenTelemetryLoggingExtensions.cs 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 660d5b5 into open-telemetry:main May 10, 2023
@CodeBlanch CodeBlanch deleted the sdk-logs-iloggerupdates branch May 10, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants