-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[di] Expose a detached MeterProviderBuilder extension on IServiceCollection which may modify services #4517
Merged
CodeBlanch
merged 10 commits into
open-telemetry:main
from
CodeBlanch:di-configuremetrics-withservices
May 31, 2023
Merged
[di] Expose a detached MeterProviderBuilder extension on IServiceCollection which may modify services #4517
CodeBlanch
merged 10 commits into
open-telemetry:main
from
CodeBlanch:di-configuremetrics-withservices
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n which may modify services.
...lderExtensions/Metrics/OpenTelemetryDependencyInjectionMetricsServiceCollectionExtensions.cs
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4517 +/- ##
==========================================
+ Coverage 85.20% 85.32% +0.11%
==========================================
Files 318 319 +1
Lines 12620 12634 +14
==========================================
+ Hits 10753 10780 +27
+ Misses 1867 1854 -13
|
alanwest
approved these changes
May 31, 2023
vishweshbankwar
approved these changes
May 31, 2023
2 tasks
mfogliatto
pushed a commit
to mfogliatto/opentelemetry-dotnet
that referenced
this pull request
Jun 10, 2023
…ection which may modify services (open-telemetry#4517)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4508
Changes
IServiceCollection.ConfigureOpenTelemetryMeterProvider
extension which doesn't requireIServiceProvider
and allows forIServiceCollection
modification.Public API Changes
namespace OpenTelemetry.Trace { public static class OpenTelemetryDependencyInjectionMetricsServiceCollectionExtensions { + public static IServiceCollection ConfigureOpenTelemetryMeterProvider(this IServiceCollection services, Action<MeterProviderBuilder> configure) {} } }
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes