-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments to package dependency to clarify the direction #4550
Add comments to package dependency to clarify the direction #4550
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4550 +/- ##
=======================================
Coverage 85.11% 85.12%
=======================================
Files 320 320
Lines 12679 12679
=======================================
+ Hits 10792 10793 +1
+ Misses 1887 1886 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as I'm not actually all that concerned if we always decide to stay on latest DiagnosticSource, but separately, I would like to better understand what is coming in .NET 8 that necessitates a DS version bump.
.NET 8 is improving dependency injection support for Meter/Instrument
It's my understanding that this support may actually be shipped in a new package Microsoft.Extensions.Diagnostics.
I guess the more interesting thing that is coming in DS v8 for our purposes is support for instrumentation scope attributes on Meter
. Would be nice to see this for ActivitySource
too.
ea65253
to
ad8bf04
Compare
Thanks! I agree with what you mentioned here, updated the PR to provider better/accurate examples. |
Here is a subset (scoped to metrics) https://github.com/dotnet/runtime/issues?q=is%3Aopen+label%3Aarea-System.Diagnostics.Metric+milestone%3A8.0.0 FYI @alanwest |
I think this will help to clarify the direction and also help to provide context/clarity to contributors (e.g. https://github.com/open-telemetry/opentelemetry-dotnet/pull/4548/files#r1220139771).