Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exemplars for 1.6.0 prerelease versions #4553

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jun 7, 2023

Changes

Merge requirement checklist

  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team June 7, 2023 01:50
@utpilla utpilla changed the title Add Exemplars Add Exemplars for 1.6.0 prerelease versions Jun 7, 2023
@utpilla utpilla requested a review from cijothomas June 7, 2023 01:53
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #4553 (cc84462) into main (6e73bb9) will decrease coverage by 0.22%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4553      +/-   ##
==========================================
- Coverage   85.42%   85.20%   -0.22%     
==========================================
  Files         320      320              
  Lines       12641    12677      +36     
==========================================
+ Hits        10798    10801       +3     
- Misses       1843     1876      +33     
Impacted Files Coverage Δ
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% <ø> (ø)
...tryProtocol/Implementation/MetricItemExtensions.cs 86.59% <ø> (-8.26%) ⬇️
.../Metrics/Builder/MeterProviderBuilderExtensions.cs 83.76% <ø> (ø)
...emetry/Metrics/Exemplar/AlwaysOffExemplarFilter.cs 0.00% <ø> (ø)
...lemetry/Metrics/Exemplar/AlwaysOnExemplarFilter.cs 100.00% <ø> (ø)
src/OpenTelemetry/Metrics/Exemplar/Exemplar.cs 100.00% <ø> (ø)
...metry/Metrics/Exemplar/TraceBasedExemplarFilter.cs 0.00% <ø> (ø)
src/OpenTelemetry/Metrics/MetricPoint.cs 61.79% <ø> (ø)

... and 3 files with indirect coverage changes

@utpilla utpilla merged commit b911e7e into open-telemetry:main Jun 7, 2023
mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
@utpilla utpilla deleted the utpilla/Add-Exemplars branch November 23, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants