-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp log exporter] Move logs extension methods to main otlp package #4556
[otlp log exporter] Move logs extension methods to main otlp package #4556
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4556 +/- ##
==========================================
- Coverage 85.20% 85.19% -0.01%
==========================================
Files 320 320
Lines 12678 12678
==========================================
- Hits 10802 10801 -1
- Misses 1876 1877 +1
|
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpLogExporterHelperExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpLogExporterHelperExtensions.cs
Show resolved
Hide resolved
…ithub.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/move-otlp-logs-extension-to-main
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 Finally! One OTLP exporter to rule them all!
Oh, we should definitely add a changelog entry for this change. |
…ithub.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/move-otlp-logs-extension-to-main
Towards #4454
Design discussion issue #
Changes
This PR moves the logs extension methods to
OpenTelemetry.Exporter.OpenTelemetryProtocol
package and deletesOpenTelemetry.Exporter.OpenTelemetryProtocol.Logs
.Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes