Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[di-logs] Expose logging implementation as public #4558

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

CodeBlanch
Copy link
Member

Relates to #4433

Changes

  • Exposes the logging implementation in OpenTelemetry.Api.ProviderBuilderExtensions and removes the added InternalsVisibleTos

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch requested a review from a team June 7, 2023 19:48
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #4558 (de399a4) into main (9e8c704) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4558   +/-   ##
=======================================
  Coverage   85.18%   85.19%           
=======================================
  Files         320      320           
  Lines       12677    12677           
=======================================
+ Hits        10799    10800    +1     
+ Misses       1878     1877    -1     
Impacted Files Coverage Δ
...endencyInjectionLoggerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...encyInjectionLoggingServiceCollectionExtensions.cs 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit f786f59 into open-telemetry:main Jun 7, 2023
@CodeBlanch CodeBlanch deleted the di-logs-publicapi branch June 7, 2023 21:05
mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants