-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prometheus exporter name and unit processing #4753
Update Prometheus exporter name and unit processing #4753
Conversation
...Telemetry.Exporter.Prometheus.AspNetCore/OpenTelemetry.Exporter.Prometheus.AspNetCore.csproj
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusMetric.cs
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4753 +/- ##
==========================================
+ Coverage 82.12% 82.40% +0.27%
==========================================
Files 313 314 +1
Lines 12783 12910 +127
==========================================
+ Hits 10498 10638 +140
+ Misses 2285 2272 -13
|
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusMetric.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializerExt.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusMetric.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/PrometheusMetricTests.cs
Show resolved
Hide resolved
…ometheusMetric.cs Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusCollectionManager.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializerExt.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusMetric.cs
Show resolved
Hide resolved
There are some failing tests. Are they broken by this PR or flaky tests? |
Not related to your PR. That's a flaky test. Tracking issue #4763 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a CHANGELOG update
I'd like to get this in for the next OTel release. Also, I'd like to be able to use these changes right now from the nightly feed. What work remains before this can be merged? |
@JamesNK I'm happy to merge but I do think this is a substantial change we should mention in the logs:
Something like this should work... ## Unreleased
* Added support for unit and name conversion following the [OpenTelemetry Specification](https://github.com/open-telemetry/opentelemetry-specification/blob/065b25024549120800da7cda6ccd9717658ff0df/specification/compatibility/prometheus_and_openmetrics.md?plain=1#L235-L240)
([#4753](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4753)) |
Done. |
Fixes #4742
Design discussion issue #
Changes
Updates the .NET Prometheus exporter to follow the metric and unit naming rules.
See https://github.com/open-telemetry/opentelemetry-specification/blob/b2f923fb1650dde1f061507908b834035506a796/specification/compatibility/prometheus_and_openmetrics.md#otlp-metric-points-to-prometheus
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes