Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lock for PrometheusCollectionManager #4760

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Aug 10, 2023

Similar to the fix made in #4031

Changes

  • Use Interlocked.Exchange to set globalLockState to zero instead of a simple assignment

@utpilla utpilla requested a review from a team August 10, 2023 02:51
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #4760 (0ec8ba5) into main (b0ab8d5) will increase coverage by 0.04%.
Report is 4 commits behind head on main.
The diff coverage is 61.01%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4760      +/-   ##
==========================================
+ Coverage   82.05%   82.09%   +0.04%     
==========================================
  Files         313      313              
  Lines       12742    12784      +42     
==========================================
+ Hits        10455    10495      +40     
- Misses       2287     2289       +2     
Files Changed Coverage Δ
src/OpenTelemetry/Metrics/AggregatorStore.cs 81.81% <48.78%> (-3.60%) ⬇️
src/Shared/Options/ConfigurationExtensions.cs 96.00% <71.42%> (-4.00%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 75.82% <100.00%> (ø)
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 91.66% <100.00%> (+0.04%) ⬆️
src/OpenTelemetry/Metrics/Metric.cs 95.78% <100.00%> (+0.04%) ⬆️
src/OpenTelemetry/Metrics/MetricReaderExt.cs 87.17% <100.00%> (+0.45%) ⬆️

... and 7 files with indirect coverage changes

@utpilla utpilla merged commit cf0b4d7 into open-telemetry:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants