-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork in persistent storage implementation to otlp #4793
Fork in persistent storage implementation to otlp #4793
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4793 +/- ##
==========================================
- Coverage 85.59% 83.44% -2.16%
==========================================
Files 284 292 +8
Lines 11686 11987 +301
==========================================
- Hits 10003 10002 -1
- Misses 1683 1985 +302
|
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/PersistentStorage/DirectorySizeTracker.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/PersistentStorage/FileBlob.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/PersistentStorage/FileBlobProvider.cs
Outdated
Show resolved
Hide resolved
…rage/FileBlob.cs Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
…rage/FileBlobProvider.cs Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
...enTelemetry.Exporter.OpenTelemetryProtocol/PersistentStorage/PersistentStorageEventSource.cs
Show resolved
Hide resolved
I assume PersistentStorage will continue to be maintained in the contrib repo. If so I would expect PRs like this to be easy reviews with no alterations to the code (alterations should be done in the contrib repo) other than marking things internal, of course. Lifting this code into the main repo is a fine strategy in the interim, though I think we need a little documentation for how we aim to maintain this lifted code. A README in the PersistentStorage directory would suffice - with links to the real source and a simple outline of steps for keeping it up to date if necessary. |
…//github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/add-persistent-storage-apis-to-otlp
👍 Added Readme. |
…//github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/add-persistent-storage-apis-to-otlp
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/PersistentStorage/README.md
Outdated
Show resolved
Hide resolved
…rage/README.md Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
Towards #4791
Design discussion issue #
Changes
This PR forks in OpenTelemetry.PersistentStorage.Abstractions and OpenTelemetry.PersistentStorage.FileSystem into the otlp exporter package. The APIs from this package will be used for adding retry support via persistent storage.
The code is copied as is. It defines new constant for enabling as is copy
<DefineConstants>BUILDING_INTERNAL_PERSISTENT_STORAGE</DefineConstants>
Reference PR open-telemetry/opentelemetry-dotnet-contrib#1320
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes