-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the character limit of the Meter instrument name #4798
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4798 +/- ##
==========================================
- Coverage 85.60% 85.58% -0.02%
==========================================
Files 284 284
Lines 11686 11686
==========================================
- Hits 10004 10002 -2
- Misses 1682 1684 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Please add an entry to changelog.md file as this is user facing change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw a typo from the PR description:
"Changed the limit of the instrument name regex from 63 to 244 as specified"
should be 254 instead of 244.
@Yun-Ting Thanks. I adjusted the description. |
Design discussion issue #4774
Changes
Changed the limit of the instrument name regex from 63 to 255 as specified here in the Open Telemetry metrics API specification.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes