Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the character limit of the Meter instrument name #4798

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

B3zaleel
Copy link
Contributor

@B3zaleel B3zaleel commented Aug 23, 2023

Design discussion issue #4774

Changes

Changed the limit of the instrument name regex from 63 to 255 as specified here in the Open Telemetry metrics API specification.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 23, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@B3zaleel B3zaleel marked this pull request as ready for review August 23, 2023 09:47
@B3zaleel B3zaleel requested a review from a team August 23, 2023 09:47
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4798 (1d15d75) into main (0d1cc36) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4798      +/-   ##
==========================================
- Coverage   85.60%   85.58%   -0.02%     
==========================================
  Files         284      284              
  Lines       11686    11686              
==========================================
- Hits        10004    10002       -2     
- Misses       1682     1684       +2     
Files Changed Coverage Δ
...lemetry/Metrics/Builder/MeterProviderBuilderSdk.cs 95.08% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Please add an entry to changelog.md file as this is user facing change.

Copy link
Contributor

@Yun-Ting Yun-Ting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Copy link
Contributor

@Yun-Ting Yun-Ting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw a typo from the PR description:
"Changed the limit of the instrument name regex from 63 to 244 as specified"
should be 254 instead of 244.

@utpilla utpilla merged commit e330e57 into open-telemetry:main Aug 23, 2023
@B3zaleel
Copy link
Contributor Author

Just saw a typo from the PR description: "Changed the limit of the instrument name regex from 63 to 244 as specified" should be 254 instead of 244.

@Yun-Ting Thanks. I adjusted the description.

@B3zaleel B3zaleel deleted the issue-4774 branch August 23, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants