Update default value for simple exemplar reservoir size #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
==========================================
+ Coverage 83.46% 83.52% +0.05%
==========================================
Files 292 292
Lines 11987 11987
==========================================
+ Hits 10005 10012 +7
+ Misses 1982 1975 -7
|
cijothomas
approved these changes
Aug 26, 2023
| @@ -5,6 +5,9 @@ | |||
| * Increased the character limit of the Meter instrument name from 63 to 255. | |||
| ([#4774](https://github.com/open-telemetry/opentelemetry-dotnet/issues/4774)) | |||
|
|
|||
| * Update default size for `SimpleExemplarReservoir` to `1`. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I think it's fine to not add this. It should be okay to add this only when introducing a public API change.
vishweshbankwar
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec has provided a default value for
SimpleExemplarReservoirsize: open-telemetry/opentelemetry-specification#3670Changes
SimpleExemplarReservoirto1.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes