-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Prometheus exporter writing bool label values #4823
Fix Prometheus exporter writing bool label values #4823
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4823 +/- ##
==========================================
+ Coverage 83.90% 83.91% +0.01%
==========================================
Files 293 293
Lines 11998 12001 +3
==========================================
+ Hits 10067 10071 +4
+ Misses 1931 1930 -1
|
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializer.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializer.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JamesNK Could you add a CHANGELOG entry for this?
Done |
Fixes #4822
Design discussion issue #
Changes
Prometheus exporter writes bool label values as lowercase
true
andfalse
strings.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes