Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Prometheus exporter writing bool label values #4823

Merged
merged 7 commits into from
Sep 7, 2023

Conversation

JamesNK
Copy link
Contributor

@JamesNK JamesNK commented Sep 4, 2023

Fixes #4822
Design discussion issue #

Changes

Prometheus exporter writes bool label values as lowercase true and false strings.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@JamesNK JamesNK requested a review from a team September 4, 2023 09:33
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #4823 (1c59639) into main (5cc1f39) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 1c59639 differs from pull request most recent head dbe03cf. Consider uploading reports for the commit dbe03cf to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4823      +/-   ##
==========================================
+ Coverage   83.90%   83.91%   +0.01%     
==========================================
  Files         293      293              
  Lines       11998    12001       +3     
==========================================
+ Hits        10067    10071       +4     
+ Misses       1931     1930       -1     
Files Changed Coverage
...heus.HttpListener/Internal/PrometheusSerializer.cs 100.00%

Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesNK Could you add a CHANGELOG entry for this?

@JamesNK
Copy link
Contributor Author

JamesNK commented Sep 7, 2023

Done

@utpilla utpilla merged commit 1f6d2cc into open-telemetry:main Sep 7, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus exporter writes boolean values as "True" and "False"
6 participants