-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk] Build extension behavior tweaks #4885
Merged
CodeBlanch
merged 8 commits into
open-telemetry:main
from
CodeBlanch:sdk-build-extension-noop-providers
Sep 28, 2023
Merged
[sdk] Build extension behavior tweaks #4885
CodeBlanch
merged 8 commits into
open-telemetry:main
from
CodeBlanch:sdk-build-extension-noop-providers
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a no-op instance instead of null for custom builders.
reyang
reviewed
Sep 25, 2023
src/OpenTelemetry/Metrics/Builder/MeterProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #4885 +/- ##
=======================================
Coverage 82.93% 82.93%
=======================================
Files 294 294
Lines 12198 12200 +2
=======================================
+ Hits 10116 10118 +2
Misses 2082 2082
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodeBlanch
added
pkg:OpenTelemetry.Api
Issues related to OpenTelemetry.Api NuGet package
pkg:OpenTelemetry
Issues related to OpenTelemetry NuGet package
labels
Sep 27, 2023
pjanotti
approved these changes
Sep 28, 2023
reyang
approved these changes
Sep 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:OpenTelemetry.Api
Issues related to OpenTelemetry.Api NuGet package
pkg:OpenTelemetry
Issues related to OpenTelemetry NuGet package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Build
extension for traces & metrics so that it isn't possible for anull
to be returned, aNotSupportedException
will be thrown for invalid builder types (logs updated to also throw)protected
ctor on APILoggerProvider
to make it consistent with traces & metrics.Details
Right now it is possible for a
null
to be returned which ripples through the annotations and into calling code ex:opentelemetry-dotnet/docs/metrics/getting-started-prometheus-grafana/Program.cs
Line 55 in 9302891
The goal with this change is to eliminate the need for
null
checking in order to simplify the user experience and docs.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes