Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up TFMs for tests #4907

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 30, 2023

Similar to #4903 and #4904, for test cases.

@reyang reyang requested a review from a team September 30, 2023 02:11
@reyang reyang mentioned this pull request Sep 30, 2023
4 tasks
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #4907 (b2f72a1) into main (23b041c) will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4907      +/-   ##
==========================================
+ Coverage   82.89%   83.22%   +0.33%     
==========================================
  Files         294      294              
  Lines       12206    12206              
==========================================
+ Hits        10118    10159      +41     
+ Misses       2088     2047      -41     
Flag Coverage Δ
unittests 83.22% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@reyang reyang closed this Sep 30, 2023
@reyang reyang reopened this Sep 30, 2023
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit b22c7a9 into open-telemetry:main Oct 2, 2023
50 of 52 checks passed
@reyang reyang deleted the reyang/test-TFMs branch March 2, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants