Add .NET8.0 targets to projects

[vishweshbankwar]

Adds .NET8.0 target to all projects.

[codecov]

Codecov Report

Merging #4918 (1be9bb8) into main (83ea1ec) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4918      +/-   ##
==========================================
+ Coverage   83.28%   83.30%   +0.01%     
==========================================
  Files         295      295              
  Lines       12360    12361       +1     
==========================================
+ Hits        10294    10297       +3     
+ Misses       2066     2064       -2     

Flag	Coverage Δ
unittests	83.30% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...metheus.AspNetCore/PrometheusExporterMiddleware.cs	62.06% <100.00%> (+1.35%)	⬆️

... and 8 files with indirect coverage changes

[Yun-Ting]

LGTM! Thank you.

[CodeBlanch]

See comment about unshipped vs shipped files.

[CodeBlanch]

I asked @Yun-Ting if this was required for AOT and she said: no. So my question is, why do we need net8.0 on all the targets?

[utpilla]

I asked @Yun-Ting if this was required for AOT and she said: no. So my question is, why do we need net8.0 on all the targets?

This goes back to the discussion for #4595, which added a net6.0 target to every project even if a particular project didn't really need any API from .NET 6. I think back then we agreed that doing this comes with a few benefits: overall ease of maintenance, newer code analysis etc.

[reyang]

I asked @Yun-Ting if this was required for AOT and she said: no. So my question is, why do we need net8.0 on all the targets?

I think the answer is YES now. @Yun-Ting to confirm.

[vishweshbankwar]

I asked @Yun-Ting if this was required for AOT and she said: no. So my question is, why do we need net8.0 on all the targets?

This goes back to the discussion for #4595, which added a net6.0 target to every project even if a particular project didn't really need any API from .NET 6. I think back then we agreed that doing this comes with a few benefits: overall ease of maintenance, newer code analysis etc.

+1 And eventually .net6.0 targets will be removed next year.

[reyang]

I asked @Yun-Ting if this was required for AOT and she said: no. So my question is, why do we need net8.0 on all the targets?

This goes back to the discussion for #4595, which added a net6.0 target to every project even if a particular project didn't really need any API from .NET 6. I think back then we agreed that doing this comes with a few benefits: overall ease of maintenance, newer code analysis etc.

+1 And eventually .net6.0 targets will be removed next year.

+1

[CodeBlanch]

I think back then we agreed that doing this comes with a few benefits: overall ease of maintenance, newer code analysis etc.

• Overall ease of maintenance I disagree with. Each new target adds a lot of maintenance burden. Api files to maintain being the primary headache. When it comes time to remove net6.0 we can add whatever new supported target we need then. That way we lose the api files for one framework and gain them for another (net zero). Right now we are gaining burden for unclear benefit (for me).

• Code analysis comes with the SDK, not the targets. By upgrading to .NET 8 SDK we have already gained that. PS: For most projects we're not currently running the analyzers 🤣

I think we should consider adding the targets if/when we actually need something.

[CodeBlanch]

I'm not totally convinced adding these targets is good, but the work LGTM 😄

[Yun-Ting]

I asked @Yun-Ting if this was required for AOT and she said: no. So my question is, why do we need net8.0 on all the targets?

I think the answer is YES now. @Yun-Ting to confirm.

The benefits of bringing net8 to the projects are that we are able to access to new APIs and we can get better AOT/trimming experience at build-time if targeting net8 directly.

cc @eerhardt, @vitek-karas

[vitek-karas]

Code analysis comes with the SDK, not the targets. By upgrading to .NET 8 SDK we have already gained that. PS: For most projects we're not currently running the analyzers 🤣

This actually is not the case for trimming/AOT analyzer. Those are tied to the TFM of the project. (This is intentional because there's some interaction between the analyzers and the framework methods being annotated and maintaining a working matrix would be a giant headache).

That said, I would not consider this the sole reason to upgrade (unless you have more specific needs which are met by the upgrade). There will be some slight differences in analyzer and Native AOT compiler behavior anyway and in case of discrepancies the NativeAOT compiler is always the correct one (presuming no bugs in the compiler). It should be enough to run the AOT test app (in CI and locally) targeting net8.0 as that will get you the .NET 8 NativeAOT compiler (the compiler also versions with the TFM of the app, not the SDK).