-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Moq dependency from Instrumentation.AspNetCore.Tests #5123
Merged
utpilla
merged 8 commits into
open-telemetry:main
from
ngruson:remove-moq-instrumentation-aspnetcore-tests
Dec 6, 2023
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
41215f1
Removed Moq dependency from Instrumentation.AspNetCore.Tests
ngruson 33a57f7
Merge branch 'main' into remove-moq-instrumentation-aspnetcore-tests
ngruson 38de305
Merge branch 'main' into remove-moq-instrumentation-aspnetcore-tests
ngruson d37bf63
Define traceId, spanId as individual fields
ngruson 9a552d6
Init InjectValues property
ngruson f202cbf
Removed PropagationContextEventArgs
ngruson d1e8510
Merge branch 'main' into remove-moq-instrumentation-aspnetcore-tests
ngruson 39a9998
Merge branch 'main' into remove-moq-instrumentation-aspnetcore-tests
utpilla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
test/OpenTelemetry.Tests/Shared/CustomTextMapPropagator.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
// <copyright file="CustomTextMapPropagator.cs" company="OpenTelemetry Authors"> | ||
// Copyright The OpenTelemetry Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// </copyright> | ||
|
||
using System.Diagnostics; | ||
using OpenTelemetry.Context.Propagation; | ||
|
||
namespace OpenTelemetry.Tests; | ||
|
||
internal sealed class CustomTextMapPropagator : TextMapPropagator | ||
{ | ||
private static readonly PropagationContext DefaultPropagationContext = default; | ||
|
||
public ActivityTraceId TraceId { get; set; } | ||
|
||
public ActivitySpanId SpanId { get; set; } | ||
|
||
public Action<PropagationContext> Injected { get; set; } | ||
|
||
public override ISet<string> Fields => null; | ||
|
||
#pragma warning disable SA1201 // Elements should appear in the correct order | ||
#pragma warning disable SA1010 // Opening square brackets should be spaced correctly | ||
public Dictionary<string, Func<PropagationContext, string>> InjectValues = []; | ||
#pragma warning restore SA1010 // Opening square brackets should be spaced correctly | ||
#pragma warning restore SA1201 // Elements should appear in the correct order | ||
|
||
public override PropagationContext Extract<T>(PropagationContext context, T carrier, Func<T, string, IEnumerable<string>> getter) | ||
{ | ||
if (this.TraceId != default && this.SpanId != default) | ||
{ | ||
return new PropagationContext( | ||
new ActivityContext( | ||
this.TraceId, | ||
this.SpanId, | ||
ActivityTraceFlags.Recorded), | ||
default); | ||
} | ||
|
||
return DefaultPropagationContext; | ||
} | ||
|
||
public override void Inject<T>(PropagationContext context, T carrier, Action<T, string, string> setter) | ||
{ | ||
foreach (var kv in this.InjectValues) | ||
{ | ||
setter(carrier, kv.Key, kv.Value.Invoke(context)); | ||
} | ||
|
||
this.Injected?.Invoke(context); | ||
} | ||
} |
24 changes: 24 additions & 0 deletions
24
test/OpenTelemetry.Tests/Shared/PropagationContextEventArgs.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// <copyright file="PropagationContextEventArgs.cs" company="OpenTelemetry Authors"> | ||
// Copyright The OpenTelemetry Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// </copyright> | ||
|
||
using OpenTelemetry.Context.Propagation; | ||
|
||
namespace OpenTelemetry.Tests; | ||
|
||
internal class PropagationContextEventArgs(PropagationContext context) : EventArgs | ||
{ | ||
public PropagationContext Context { get; private set; } = context; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be removed now that we are using Action delegate