Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-extensions-logs] ExperimentalAttribute decoration for experimental APIs #5148

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

CodeBlanch
Copy link
Member

Follow-up to #4963

Changes

  • Adds .NET 8 ExperimentalAttribute decoration for experimental log APIs in OpenTelemetry.Api.ProviderBuilderExtensions

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

…n OpenTelemetry.Api.ProviderBuilderExtensions.
@CodeBlanch CodeBlanch requested a review from a team December 8, 2023 17:52
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #5148 (3dbbfa9) into main (f075128) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5148   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files         297      297           
  Lines       12380    12380           
=======================================
  Hits        10287    10287           
  Misses       2093     2093           
Flag Coverage Δ
unittests 83.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...endencyInjectionLoggerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...encyInjectionLoggingServiceCollectionExtensions.cs 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@utpilla utpilla merged commit ecef81d into open-telemetry:main Dec 8, 2023
40 checks passed
@CodeBlanch CodeBlanch deleted the api-extensions-diagnostics branch December 8, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants