Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MinVerTagPrefix for AspNetCore and Http instrumentation libraries #5170

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Add MinVerTagPrefix for AspNetCore and Http instrumentation libraries #5170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
795401c
Add separate MinVerTagPrefix for Http and AspNetCore instrumentation
utpilla Dec 13, 2023
7b854c3
Update RELEASING doc
utpilla Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion build/RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,16 @@ Only for Maintainers.
git push origin 1.0.0-rc9.7
```

If releasing both, push both tags above.
If releasing only a particular non-core component which has a dedicated
MinverTagPrefix such as AspNetCore instrumentation, only add and push the
tag with that particular prefix. For example:

```sh
git tag -a Instrumentation.AspNetCore-1.6.0 -m "1.6.0 of AspNetCore instrumentation library"
git push origin Instrumentation.AspNetCore-1.6.0
```

If releasing multiple kinds of components, push both tags for each of them.

7. Go to the [list of
tags](https://github.com/open-telemetry/opentelemetry-dotnet/tags)
Expand Down
1 change: 1 addition & 0 deletions src/OpenTelemetry.Instrumentation.AspNetCore/OpenTelemetry.Instrumentation.AspNetCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks>$(TargetFrameworksForAspNetCoreInstrumentation)</TargetFrameworks>
<Description>ASP.NET Core instrumentation for OpenTelemetry .NET</Description>
<PackageTags>$(PackageTags);distributed-tracing;AspNetCore</PackageTags>
<MinVerTagPrefix>Instrumentation.AspNetCore-</MinVerTagPrefix>
<IncludeDiagnosticSourceInstrumentationHelpers>true</IncludeDiagnosticSourceInstrumentationHelpers>

<!-- this is temporary. will remove in future PR. -->
Expand Down
1 change: 1 addition & 0 deletions src/OpenTelemetry.Instrumentation.Http/OpenTelemetry.Instrumentation.Http.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks>$(TargetFrameworksForLibraries)</TargetFrameworks>
<Description>Http instrumentation for OpenTelemetry .NET</Description>
<PackageTags>$(PackageTags);distributed-tracing</PackageTags>
<MinVerTagPrefix>Instrumentation.Http-</MinVerTagPrefix>
<IncludeDiagnosticSourceInstrumentationHelpers>true</IncludeDiagnosticSourceInstrumentationHelpers>

<!-- this is temporary. will remove in future PR. -->
Expand Down