Add support for OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS

src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreInstrumentationMeterProviderBuilderExtensions.cs

@@ -27,9 +27,8 @@ public static MeterProviderBuilder AddAspNetCoreInstrumentation(
 #if NET8_0_OR_GREATER
         return builder.ConfigureMeters();
 #else
-        // Note: Warm-up the status code and method mapping.
+        // Note: Warm-up the status code.
         _ = TelemetryHelper.BoxedStatusCodes;
-        _ = RequestMethodHelper.KnownMethods;
 
         builder.AddMeter(HttpInMetricsListener.InstrumentationName);
 

src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreInstrumentationTracerProviderBuilderExtensions.cs

@@ -50,9 +50,8 @@ public static TracerProviderBuilder AddAspNetCoreInstrumentation(
     {
         Guard.ThrowIfNull(builder);
 
-        // Note: Warm-up the status code and method mapping.
+        // Note: Warm-up the status code.
         _ = TelemetryHelper.BoxedStatusCodes;
-        _ = RequestMethodHelper.KnownMethods;
 
         name ??= Options.DefaultName;
 

src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreTraceInstrumentationOptions.cs

@@ -29,6 +29,15 @@ internal AspNetCoreTraceInstrumentationOptions(IConfiguration configuration)
         {
             this.EnableGrpcAspNetCoreSupport = enableGrpcInstrumentation;
         }
+
+        if (configuration.TryGetStringValue("OTEL_INSTRUMENTATION_HTTP_KNOWN_METHODS", out var knownHttpMethods))
+        {
+            this.KnownHttpMethods = knownHttpMethods
+                .Split(',')
+                .Select(x => x.Trim())
+                .Where(x => !string.IsNullOrEmpty(x))
+                .ToList();
+        }
     }
 
     /// <summary>
@@ -91,4 +100,7 @@ internal AspNetCoreTraceInstrumentationOptions(IConfiguration configuration)
     /// https://github.com/open-telemetry/semantic-conventions/blob/main/docs/rpc/rpc-spans.md.
     /// </remarks>
     internal bool EnableGrpcAspNetCoreSupport { get; set; }
+
+    internal List<string> KnownHttpMethods { get; set; } =
+        [];
 }

src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs

@@ -58,13 +58,15 @@ internal class HttpInListener : ListenerHandler
     private readonly PropertyFetcher<string> beforeActionTemplateFetcher = new("Template");
 #endif
     private readonly AspNetCoreTraceInstrumentationOptions options;
+    private readonly RequestMethodHelper requestMethodHelper;
 
     public HttpInListener(AspNetCoreTraceInstrumentationOptions options)
         : base(DiagnosticSourceName)
     {
         Guard.ThrowIfNull(options);
 
         this.options = options;
+        this.requestMethodHelper = new RequestMethodHelper(this.options.KnownHttpMethods);
     }
 
     public override void OnEventWritten(string name, object payload)
@@ -105,8 +107,7 @@ public void OnStartActivity(Activity activity, object payload)
         // By this time, samplers have already run and
         // activity.IsAllDataRequested populated accordingly.
 
-        HttpContext context = payload as HttpContext;
-        if (context == null)
+        if (payload is not HttpContext context)
         {
             AspNetCoreInstrumentationEventSource.Log.NullPayload(nameof(HttpInListener), nameof(this.OnStartActivity), activity.OperationName);
             return;
@@ -176,7 +177,7 @@ public void OnStartActivity(Activity activity, object payload)
 #endif
 
             var path = (request.PathBase.HasValue || request.Path.HasValue) ? (request.PathBase + request.Path).ToString() : "/";
-            activity.DisplayName = GetDisplayName(request.Method);
+            activity.DisplayName = this.GetDisplayName(request.Method);
 
             // see the spec https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/http/http-spans.md
 
@@ -196,7 +197,7 @@ public void OnStartActivity(Activity activity, object payload)
                 activity.SetTag(SemanticConventions.AttributeUrlQuery, request.QueryString.Value);
             }
 
-            RequestMethodHelper.SetHttpMethodTag(activity, request.Method);
+            this.requestMethodHelper.SetHttpMethodTag(activity, request.Method);
 
             activity.SetTag(SemanticConventions.AttributeUrlScheme, request.Scheme);
             activity.SetTag(SemanticConventions.AttributeUrlPath, path);
@@ -226,8 +227,7 @@ public void OnStopActivity(Activity activity, object payload)
     {
         if (activity.IsAllDataRequested)
         {
-            HttpContext context = payload as HttpContext;
-            if (context == null)
+            if (payload is not HttpContext context)
             {
                 AspNetCoreInstrumentationEventSource.Log.NullPayload(nameof(HttpInListener), nameof(this.OnStopActivity), activity.OperationName);
                 return;
@@ -239,7 +239,7 @@ public void OnStopActivity(Activity activity, object payload)
             var routePattern = (context.GetEndpoint() as RouteEndpoint)?.RoutePattern.RawText;
             if (!string.IsNullOrEmpty(routePattern))
             {
-                activity.DisplayName = GetDisplayName(context.Request.Method, routePattern);
+                activity.DisplayName = this.GetDisplayName(context.Request.Method, routePattern);
                 activity.SetTag(SemanticConventions.AttributeHttpRoute, routePattern);
             }
 #endif
@@ -382,9 +382,9 @@ private static void AddGrpcAttributes(Activity activity, string grpcMethod, Http
         }
     }
 
-    private static string GetDisplayName(string httpMethod, string httpRoute = null)
+    private string GetDisplayName(string httpMethod, string httpRoute = null)
     {
-        var normalizedMethod = RequestMethodHelper.GetNormalizedHttpMethod(httpMethod);
+        var normalizedMethod = this.requestMethodHelper.GetNormalizedHttpMethod(httpMethod);
 
         return string.IsNullOrEmpty(httpRoute)
             ? normalizedMethod

src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs

@@ -84,7 +84,8 @@ public static void OnStopEventWritten(string name, object payload)
         tags.Add(new KeyValuePair<string, object>(SemanticConventions.AttributeUrlScheme, context.Request.Scheme));
         tags.Add(new KeyValuePair<string, object>(SemanticConventions.AttributeHttpResponseStatusCode, TelemetryHelper.GetBoxedStatusCode(context.Response.StatusCode)));
 
-        var httpMethod = RequestMethodHelper.GetNormalizedHttpMethod(context.Request.Method);
+        var requestMethodHelper = new RequestMethodHelper(string.Empty);
+        var httpMethod = requestMethodHelper.GetNormalizedHttpMethod(context.Request.Method);
         tags.Add(new KeyValuePair<string, object>(SemanticConventions.AttributeHttpRequestMethod, httpMethod));
 
 #if NET6_0_OR_GREATER

src/OpenTelemetry.Instrumentation.Http/HttpClientInstrumentationMeterProviderBuilderExtensions.cs

@@ -32,9 +32,8 @@ public static MeterProviderBuilder AddHttpClientInstrumentation(
             .AddMeter("System.Net.Http")
             .AddMeter("System.Net.NameResolution");
 #else
-        // Note: Warm-up the status code and method mapping.
+        // Note: Warm-up the status code.
         _ = TelemetryHelper.BoxedStatusCodes;
-        _ = RequestMethodHelper.KnownMethods;
 
 #if NETFRAMEWORK
         builder.AddMeter(HttpWebRequestActivitySource.MeterName);

src/OpenTelemetry.Instrumentation.Http/HttpClientInstrumentationTracerProviderBuilderExtensions.cs

@@ -47,9 +47,8 @@ public static TracerProviderBuilder AddHttpClientInstrumentation(
     {
         Guard.ThrowIfNull(builder);
 
-        // Note: Warm-up the status code and method mapping.
+        // Note: Warm-up the status code.
         _ = TelemetryHelper.BoxedStatusCodes;
-        _ = RequestMethodHelper.KnownMethods;
 
         name ??= Options.DefaultName;
 

src/OpenTelemetry.Instrumentation.Http/HttpClientTraceInstrumentationOptions.cs

@@ -125,6 +125,9 @@ public class HttpClientTraceInstrumentationOptions
     /// </remarks>
     public bool RecordException { get; set; }
 
+    internal List<string> KnownHttpMethods { get; set; } =
+        [];
+
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     internal bool EventFilterHttpRequestMessage(string activityName, object arg1)
     {

src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs

@@ -15,7 +15,7 @@
 
 namespace OpenTelemetry.Instrumentation.Http.Implementation;
 
-internal sealed class HttpHandlerDiagnosticListener : ListenerHandler
+internal sealed class HttpHandlerDiagnosticListener(HttpClientTraceInstrumentationOptions options) : ListenerHandler("HttpHandlerDiagnosticListener")
 {
     internal static readonly AssemblyName AssemblyName = typeof(HttpHandlerDiagnosticListener).Assembly.GetName();
     internal static readonly bool IsNet7OrGreater;
@@ -34,7 +34,8 @@ internal sealed class HttpHandlerDiagnosticListener : ListenerHandler
     private static readonly PropertyFetcher<HttpResponseMessage> StopResponseFetcher = new("Response");
     private static readonly PropertyFetcher<Exception> StopExceptionFetcher = new("Exception");
     private static readonly PropertyFetcher<TaskStatus> StopRequestStatusFetcher = new("RequestTaskStatus");
-    private readonly HttpClientTraceInstrumentationOptions options;
+    private readonly HttpClientTraceInstrumentationOptions options = options;
+    private readonly RequestMethodHelper requestMethodHelper = new(options.KnownHttpMethods);
 
     static HttpHandlerDiagnosticListener()
     {
@@ -48,12 +49,6 @@ static HttpHandlerDiagnosticListener()
         }
     }
 
-    public HttpHandlerDiagnosticListener(HttpClientTraceInstrumentationOptions options)
-        : base("HttpHandlerDiagnosticListener")
-    {
-        this.options = options;
-    }
-
     public override void OnEventWritten(string name, object payload)
     {
         switch (name)
@@ -135,7 +130,7 @@ public void OnStartActivity(Activity activity, object payload)
                 return;
             }
 
-            RequestMethodHelper.SetHttpClientActivityDisplayName(activity, request.Method.Method);
+            this.requestMethodHelper.SetHttpClientActivityDisplayName(activity, request.Method.Method);
 
             if (!IsNet7OrGreater)
             {
@@ -144,7 +139,7 @@ public void OnStartActivity(Activity activity, object payload)
             }
 
             // see the spec https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/http/http-spans.md
-            RequestMethodHelper.SetHttpMethodTag(activity, request.Method.Method);
+            this.requestMethodHelper.SetHttpMethodTag(activity, request.Method.Method);
 
             activity.SetTag(SemanticConventions.AttributeServerAddress, request.RequestUri.Host);
             if (!request.RequestUri.IsDefaultPort)

src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs

@@ -15,7 +15,7 @@
 
 namespace OpenTelemetry.Instrumentation.Http.Implementation;
 
-internal sealed class HttpHandlerMetricsDiagnosticListener : ListenerHandler
+internal sealed class HttpHandlerMetricsDiagnosticListener(string name) : ListenerHandler(name)
 {
     internal const string OnStopEvent = "System.Net.Http.HttpRequestOut.Stop";
 
@@ -34,10 +34,7 @@ internal sealed class HttpHandlerMetricsDiagnosticListener : ListenerHandler
     private static readonly HttpRequestOptionsKey<string> HttpRequestOptionsErrorKey = new(SemanticConventions.AttributeErrorType);
 #endif
 
-    public HttpHandlerMetricsDiagnosticListener(string name)
-        : base(name)
-    {
-    }
+    private static readonly RequestMethodHelper RequestMethodHelper = new(string.Empty);
 
     public static void OnStopEventWritten(Activity activity, object payload)
     {

src/OpenTelemetry.Instrumentation.Http/Implementation/HttpWebRequestActivitySource.netfx.cs

@@ -38,6 +38,7 @@ internal static class HttpWebRequestActivitySource
     private static readonly Histogram<double> HttpClientRequestDuration = WebRequestMeter.CreateHistogram<double>("http.client.request.duration", "s", "Measures the duration of outbound HTTP requests.");
 
     private static HttpClientTraceInstrumentationOptions tracingOptions;
+    private static RequestMethodHelper requestMethodHelper;
 
     // Fields for reflection
     private static FieldInfo connectionGroupListField;
@@ -89,18 +90,19 @@ internal static HttpClientTraceInstrumentationOptions TracingOptions
         set
         {
             tracingOptions = value;
+            requestMethodHelper = new RequestMethodHelper(tracingOptions.KnownHttpMethods);
         }
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     private static void AddRequestTagsAndInstrumentRequest(HttpWebRequest request, Activity activity)
     {
-        RequestMethodHelper.SetHttpClientActivityDisplayName(activity, request.Method);
+        requestMethodHelper.SetHttpClientActivityDisplayName(activity, request.Method);
 
         if (activity.IsAllDataRequested)
         {
             // see the spec https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/http/http-spans.md
-            RequestMethodHelper.SetHttpMethodTag(activity, request.Method);
+            requestMethodHelper.SetHttpMethodTag(activity, request.Method);
 
             activity.SetTag(SemanticConventions.AttributeServerAddress, request.RequestUri.Host);
             if (!request.RequestUri.IsDefaultPort)
@@ -359,12 +361,11 @@ private static void ProcessResult(IAsyncResult asyncResult, AsyncCallback asyncC
                     // Disposed HttpWebResponse throws when accessing properties, so let's make a copy of the data to ensure that doesn't happen.
 
                     HttpWebResponse responseCopy = httpWebResponseCtor(
-                        new object[]
-                        {
+                        [
                             uriAccessor(response), verbAccessor(response), coreResponseDataAccessor(response), mediaTypeAccessor(response),
                             usesProxySemanticsAccessor(response), DecompressionMethods.None,
                             isWebSocketResponseAccessor(response), connectionGroupNameAccessor(response),
-                        });
+                        ]);
 
                     if (activity != null)
                     {
@@ -425,7 +426,7 @@ private static void ProcessResult(IAsyncResult asyncResult, AsyncCallback asyncC
 
             TagList tags = default;
 
-            var httpMethod = RequestMethodHelper.GetNormalizedHttpMethod(request.Method);
+            var httpMethod = requestMethodHelper.GetNormalizedHttpMethod(request.Method);
             tags.Add(new KeyValuePair<string, object>(SemanticConventions.AttributeHttpRequestMethod, httpMethod));
 
             tags.Add(SemanticConventions.AttributeServerAddress, request.RequestUri.Host);