-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Remove Experimental Flag and emit stable Exception attributes by default #5258
[otlp] Remove Experimental Flag and emit stable Exception attributes by default #5258
Conversation
…ag as exception attributes are now standard.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5258 +/- ##
==========================================
- Coverage 83.38% 83.12% -0.26%
==========================================
Files 297 271 -26
Lines 12531 11967 -564
==========================================
- Hits 10449 9948 -501
+ Misses 2082 2019 -63
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent a nit on CHANGELOG but LGTM
Fixes #4831
Design discussion issue #
This PR addresses the stabilization of exception attributes in the OpenTelemetry Semantic Conventions. With
exception.type
,exception.message
, andexception.stacktrace
now considered stable, the need for theOTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES
environment variable has been eliminated.Changes
Please provide a brief description of the changes here.
OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES
environment variable.exception.type
,exception.message
, andexception.stacktrace
are automatically included in exportsMerge requirement checklist
CHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)