-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log correlation/redaction doc improvements #5262
Merged
CodeBlanch
merged 7 commits into
open-telemetry:main
from
reyang:reyang/logging-doc-improvement
Jan 26, 2024
Merged
Log correlation/redaction doc improvements #5262
CodeBlanch
merged 7 commits into
open-telemetry:main
from
reyang:reyang/logging-doc-improvement
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
reyang
commented
Jan 26, 2024
- Updated the log correlation example to follow the best practices.
- Added placeholders for enrichment and filtering to the logging best practice doc.
- Added log correlation and redaction to the logging best practice doc.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5262 +/- ##
==========================================
- Coverage 83.38% 83.01% -0.37%
==========================================
Files 297 272 -25
Lines 12531 11983 -548
==========================================
- Hits 10449 9948 -501
+ Misses 2082 2035 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cijothomas
reviewed
Jan 26, 2024
cijothomas
reviewed
Jan 26, 2024
cijothomas
approved these changes
Jan 26, 2024
CodeBlanch
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CodeBlanch
reviewed
Jan 26, 2024
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.