Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codecov/codecov-action from 3.1.5 to 4.0.1 #5294

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

CodeBlanch
Copy link
Member

Relates to #5293

There seem to be some breaking changes with v4 that dependabot isn't privy to: https://github.com/open-telemetry/opentelemetry-dotnet/actions/runs/7730817410/job/21078288994?pr=5293#step:9:35

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (6250307) 83.38% compared to head (aeecacc) 82.98%.
Report is 53 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5294      +/-   ##
==========================================
- Coverage   83.38%   82.98%   -0.41%     
==========================================
  Files         297      272      -25     
  Lines       12531    11975     -556     
==========================================
- Hits        10449     9937     -512     
+ Misses       2082     2038      -44     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.65% <47.22%> (?)
unittests-Instrumentation-Stable 24.66% <47.22%> (?)
unittests-Solution-Experimental 82.97% <77.89%> (?)
unittests-Solution-Stable 82.96% <77.89%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....Api/Context/Propagation/TraceContextPropagator.cs 90.00% <100.00%> (+0.52%) ⬆️
...etryProtocol/Implementation/ExperimentalOptions.cs 100.00% <ø> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs 100.00% <100.00%> (ø)
...rotocol/Implementation/OtlpLogRecordTransformer.cs 95.41% <100.00%> (+1.95%) ⬆️
....Prometheus.HttpListener/PrometheusHttpListener.cs 81.70% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 89.79% <100.00%> (+0.21%) ⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.74% <100.00%> (+0.26%) ⬆️
...ntation.GrpcNetClient/GrpcClientInstrumentation.cs 100.00% <100.00%> (ø)
...NetClient/GrpcClientTraceInstrumentationOptions.cs 100.00% <ø> (ø)
...ent/Implementation/GrpcClientDiagnosticListener.cs 75.80% <100.00%> (-2.77%) ⬇️
... and 14 more

... and 36 files with indirect coverage changes

@CodeBlanch
Copy link
Member Author

Waiting on this before continuing with the upgrade: codecov/codecov-action#1242

@CodeBlanch CodeBlanch marked this pull request as ready for review February 1, 2024 23:10
@CodeBlanch CodeBlanch requested a review from a team February 1, 2024 23:10
@CodeBlanch CodeBlanch changed the title Bump codecov/codecov-action from 3.1.5 to 4.0.0 Bump codecov/codecov-action from 3.1.5 to 4.0.1 Feb 1, 2024
@alanwest alanwest merged commit edfea52 into open-telemetry:main Feb 2, 2024
49 checks passed
@CodeBlanch CodeBlanch deleted the repo-ci-codecov-bump branch February 2, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants