-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metrics] Document view level cardinality limit #5321
Merged
CodeBlanch
merged 9 commits into
open-telemetry:main
from
reyang:reyang/doc-view-cardinality
Feb 7, 2024
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1984951
document view level cardinality
reyang 54874f6
nit
reyang 01c480c
nit
reyang faba0ac
address comments
reyang 19810ed
example
reyang 7e7f437
tweak
reyang 34e7fcd
Update docs/metrics/getting-started-console/README.md
reyang 29f1024
Merge branch 'main' into reyang/doc-view-cardinality
reyang de5be4f
nit
reyang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -356,18 +356,13 @@ predictable and reliable behavior when excessive cardinality happens, whether it | |
was due to a malicious attack or developer making mistakes while writing code. | ||
|
||
OpenTelemetry has a default cardinality limit of `2000` per metric. This limit | ||
can be configured at `MeterProvider` level using | ||
can be configured at `MeterProvider` level using the | ||
`SetMaxMetricPointsPerMetricStream` method, or at individual | ||
[view](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#view) | ||
level. Refer to this | ||
level using `MetricStreamConfiguration.CardinalityLimit`. Refer to this | ||
[doc](../../docs/metrics/customizing-the-sdk/README.md#changing-maximum-metricpoints-per-metricstream) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This section can be updated to be: "../../docs/metrics/customizing-the-sdk/README.md#changing-the-cardinalityLimit", given the name standardization effort: https://github.com/open-telemetry/opentelemetry-dotnet/pull/5328/files. |
||
for more information. | ||
|
||
> [!NOTE] | ||
> Setting cardinality limit per view is not yet implemented in OpenTelemetry | ||
.NET. You can track the progress by following this | ||
[issue](https://github.com/open-telemetry/opentelemetry-dotnet/issues/5296). | ||
|
||
Given a metric, once the cardinality limit is reached, any new measurement which | ||
cannot be independently aggregated because of the limit will be aggregated using | ||
the [overflow | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.