Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Otlp] Add persistent storage transmission handler #5460

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Mar 19, 2024

Towards #4791
Design discussion issue #

Changes

Adds persistent storage handler for storing telemetry on disk. The handler will retry transmitting telemetry stored on disk at regular interval.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 85.53%. Comparing base (6250307) to head (40204ab).
Report is 146 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5460      +/-   ##
==========================================
+ Coverage   83.38%   85.53%   +2.14%     
==========================================
  Files         297      290       -7     
  Lines       12531    12606      +75     
==========================================
+ Hits        10449    10782     +333     
+ Misses       2082     1824     -258     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.47% <85.71%> (?)
unittests-Solution-Stable 85.50% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tation/OpenTelemetryProtocolExporterEventSource.cs 91.66% <100.00%> (-8.34%) ⬇️
...on/Transmission/OtlpExporterTransmissionHandler.cs 94.11% <100.00%> (ø)
...tlpExporterPersistentStorageTransmissionHandler.cs 83.82% <83.82%> (ø)

... and 64 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review March 25, 2024 18:40
@vishweshbankwar vishweshbankwar requested a review from a team March 25, 2024 18:40
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vishweshbankwar and others added 3 commits March 26, 2024 11:11
…n/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
…n/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
@@ -94,6 +103,12 @@ public void TrySubmitRequestException(string ex)
this.WriteEvent(12, ex);
}

[Event(13, Message = "Error while attempting to re-transmit data from disk. Message: '{0}'", Level = EventLevel.Error)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR but it would be nice to also log the telemetry signal that was being sent. We should do it for other methods in this class too.

@utpilla utpilla merged commit af57de2 into open-telemetry:main Mar 27, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants