-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Otlp] Add persistent storage transmission handler #5460
[Otlp] Add persistent storage transmission handler #5460
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5460 +/- ##
==========================================
+ Coverage 83.38% 85.53% +2.14%
==========================================
Files 297 290 -7
Lines 12531 12606 +75
==========================================
+ Hits 10449 10782 +333
+ Misses 2082 1824 -258
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
…n/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
...etryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
@@ -94,6 +103,12 @@ public void TrySubmitRequestException(string ex) | |||
this.WriteEvent(12, ex); | |||
} | |||
|
|||
[Event(13, Message = "Error while attempting to re-transmit data from disk. Message: '{0}'", Level = EventLevel.Error)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR but it would be nice to also log the telemetry signal that was being sent. We should do it for other methods in this class too.
Towards #4791
Design discussion issue #
Changes
Adds persistent storage handler for storing telemetry on disk. The handler will retry transmitting telemetry stored on disk at regular interval.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes