-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AspNetCore, Instrumentation.Http] Fix http.request.method_original attribute #5471
Merged
utpilla
merged 4 commits into
open-telemetry:main
from
Kielek:aspnetcore-request-method-tags
Mar 27, 2024
Merged
[Instrumentation.AspNetCore, Instrumentation.Http] Fix http.request.method_original attribute #5471
utpilla
merged 4 commits into
open-telemetry:main
from
Kielek:aspnetcore-request-method-tags
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
changed the title
[Instrumentation.AspNetCore, Instrumentation.Http] Fix http.request.m…
[Instrumentation.AspNetCore, Instrumentation.Http] Fix http.request.method_original attribute
Mar 25, 2024
Kielek
force-pushed
the
aspnetcore-request-method-tags
branch
from
March 25, 2024 09:07
0f3cead
to
e94149e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5471 +/- ##
==========================================
+ Coverage 83.38% 85.53% +2.15%
==========================================
Files 297 290 -7
Lines 12531 12606 +75
==========================================
+ Hits 10449 10783 +334
+ Misses 2082 1823 -259
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ethod_original attribute
Kielek
force-pushed
the
aspnetcore-request-method-tags
branch
from
March 25, 2024 09:32
e94149e
to
41120bf
Compare
@vishweshbankwar, first part of propagation fixes from open-telemetry/opentelemetry-dotnet-contrib#1607. Please review, and merge if possible. |
pellared
approved these changes
Mar 25, 2024
test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.Basic.cs
Outdated
Show resolved
Hide resolved
vishweshbankwar
approved these changes
Mar 27, 2024
rajkumar-rangaraj
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-dotnet-contrib#1607 (comment)
Design discussion issue #
Changes
Propagates changes from open-telemetry/opentelemetry-dotnet-contrib#1607 related to
http.request.method_original
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)