Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hosting] Revert obsoletion of OpenTelemetryBuilder #5571

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Apr 25, 2024

Changes

  • Reverts obsoletion of OpenTelemetryBuilder

Details

This was causing a bit of friction with F# (#5265 (comment)) and Azure Monitor distro.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch added the pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package label Apr 25, 2024
@CodeBlanch CodeBlanch requested a review from a team April 25, 2024 22:17
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (6250307) to head (10bf225).
Report is 194 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5571      +/-   ##
==========================================
+ Coverage   83.38%   85.42%   +2.04%     
==========================================
  Files         297      282      -15     
  Lines       12531    12216     -315     
==========================================
- Hits        10449    10436      -13     
+ Misses       2082     1780     -302     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.20% <ø> (?)
unittests-Solution-Stable 85.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lemetry.Extensions.Hosting/OpenTelemetryBuilder.cs 100.00% <ø> (ø)
...ensions.Hosting/OpenTelemetryServicesExtensions.cs 100.00% <ø> (ø)

... and 78 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 0deb93e into open-telemetry:main Apr 26, 2024
33 checks passed
@CodeBlanch CodeBlanch deleted the hosting-revert-obsoletion branch April 26, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants